-
Notifications
You must be signed in to change notification settings - Fork 4.1k
engine: error out when timestamp.WallTime < 0 #21112
Copy link
Copy link
Closed
Labels
A-kv-transactionsRelating to MVCC and the transactional model.Relating to MVCC and the transactional model.C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.E-easyEasy issue to tackle, requires little or no CockroachDB experienceEasy issue to tackle, requires little or no CockroachDB experiencehelp wantedHelp is requested / needed by the one who filed the issue to fix it.Help is requested / needed by the one who filed the issue to fix it.
Description
#21070 found that we don't prohibit MVCC writes at negative timestamps. Such writes permanently corrupt the MVCC history and we should prohibit them.
Once that is done, TestMVCCStatsRandomized should be changed to allow negative timestamps (simply to have coverage for this error case).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-kv-transactionsRelating to MVCC and the transactional model.Relating to MVCC and the transactional model.C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.E-easyEasy issue to tackle, requires little or no CockroachDB experienceEasy issue to tackle, requires little or no CockroachDB experiencehelp wantedHelp is requested / needed by the one who filed the issue to fix it.Help is requested / needed by the one who filed the issue to fix it.