Skip to content

ui: mark partial aggregations (stats) as such #20691

@tbg

Description

@tbg

The UI does a decent job at returning the data it received, but it's less good at pointing out when results are incomplete.

For example,

constructor(name: string, details: TableDetailsResponse, stats: TableStatsResponse) {
this.name = name;
this.id = details && details.descriptor_id.toNumber();
this.numColumns = details && details.columns.length;
this.numIndices = details && _.uniqBy(details.indexes, idx => idx.name).length;
this.rangeCount = stats && stats.range_count && stats.range_count.toNumber();
this.createStatement = details && details.create_table_statement;
this.grants = details && details.grants;
if (stats && stats.stats) {
this.size = stats.stats.val_bytes.add(stats.stats.sys_bytes).toNumber();
}
}

if stats is empty, nothing will be shown, which makes some sense. But stats also contains a missing_nodes field and, if that is populated, we are really showing an incomplete summation and should alert the user to that fact.

There are multiple other places that are best-effort but make it look to the user as if they succeeded completely.

@dianasaur323 for triage.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-webui-databasesC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)S-3-wrong-metadataIssues causing erroneous metadata or monitoring stats to be returned.X-staleno-issue-activity

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions