-
Notifications
You must be signed in to change notification settings - Fork 4.1k
storageccl: lots of cgo calls in Backup #18884
Copy link
Copy link
Closed
Labels
A-disaster-recoveryC-performancePerf of queries or internals. Solution not expected to change functional behavior.Perf of queries or internals. Solution not expected to change functional behavior.
Description
| // TODO(dan): Move all this logic into c++ and make this a thin wrapper. |
cockroach/pkg/ccl/storageccl/export.go
Line 144 in 14c5215
| // TODO(dan): Move all this iteration into cpp to avoid the cgo calls. |
This should reduce p99 by a lot.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-disaster-recoveryC-performancePerf of queries or internals. Solution not expected to change functional behavior.Perf of queries or internals. Solution not expected to change functional behavior.