Skip to content

distsql: the Context used for expression evaluation (EvalCtx.Ctx) is wrong #15670

@andreimatei

Description

@andreimatei

As indicated by the TODO here: https://github.com/cockroachdb/cockroach/blob/549631b/pkg/sql/distsqlrun/server.go#L180

Each processor that needs to evaluate expressions should initialize the Ctx inside the EvalCtx. This would probably be made easier by making the EvalCtx immutable and passing it by value more.

Metadata

Metadata

Assignees

Labels

A-sql-executionRelating to SQL execution.C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions