-
Notifications
You must be signed in to change notification settings - Fork 4.1k
roachtest: leaked goroutines #148196
Copy link
Copy link
Open
Labels
A-testeng-foundationsA-testingTesting tools and infrastructureTesting tools and infrastructureC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-testengTestEng TeamTestEng Teambranch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.
Description
Roachtest prints leaked goroutines after successful completion.
I'm disabling this in #146990 since the leak check has been there for going on two years and few, if any, of the leaks were fixed. Dumping pages of leaked goroutines after each roachtest run is detrimental to the UX of the tool.
TE should re-enable this check only when actually preparing to cut down on the leaked goroutines. Understandably, this hasn't been a priority, and would likely regress unless coupled with some enforcement on a per-test level.
Jira issue: CRDB-51467
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-testeng-foundationsA-testingTesting tools and infrastructureTesting tools and infrastructureC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-testengTestEng TeamTestEng Teambranch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.