-
Notifications
You must be signed in to change notification settings - Fork 4.1k
roachtest: surface cloud cluster spec info in artifacts for rest of clouds #146202
Copy link
Copy link
Open
Labels
A-testeng-foundationsC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)E-quick-winLikely to be a quick win for someone experienced.Likely to be a quick win for someone experienced.T-testengTestEng TeamTestEng Team
Description
It would be nice if we could revisit GetVMSPecs and implement it for Azure:
cockroach/pkg/roachprod/vm/azure/azure.go
Lines 186 to 190 in 9252c0e
| func (p *Provider) GetVMSpecs( | |
| l *logger.Logger, vms vm.List, | |
| ) (map[string]map[string]interface{}, error) { | |
| return nil, nil | |
| } |
For a recent customer ask, we wanted to verify that a certain disk was safe to use -- validating this via roachtests. After applying #145928, we noticed that there was no ability to log the cluster specs created so that we could verify premium ssd v2 was being used (we ended up validating via Azure portal).
As a followup: it would be nice if we could turn this spec-dumping into some flag so that we can do this validation for passing roachtests as well, but up to you all if that is worth it
Jira issue: CRDB-50427
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-testeng-foundationsC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)E-quick-winLikely to be a quick win for someone experienced.Likely to be a quick win for someone experienced.T-testengTestEng TeamTestEng Team