catalog: schema descriptor validation reads all functions under a schema #138384
Description
Presently, schema descriptor validation read all function descriptors under schema. This is problematic when concurrent CREATE TABLE statements referring to any function under a schema are executed will run into frequent transaction retry errors. The following scenario is a simple repro:
Setup:
CREATE FUNCTION public.example (input INT) RETURNS INT8
LANGUAGE SQL
AS $$
SELECT input::INT8;
$$;
CREATE FUNCTION public.wrap(input INT) RETURNS INT8
LANGUAGE SQL
AS $$
SELECT public.example(input);
$$;
CREATE FUNCTION public.wrap2(input INT) RETURNS INT8
LANGUAGE SQL
AS $$
SELECT public.example(input);
$$;
Conn 1:
BEGIN;
CREATE TABLE t3(i int8 default public.wrap2(10));
Conn 2:
BEGIN;
CREATE TABLE t2(i int8 default public.wrap(10));
One of the commits above will fail with a txn retry error, since the underlying descriptor used by validation is modified. Resolving the schema will validate all functions, leading to this bug.
Jira issue: CRDB-46065
Metadata
Metadata
Assignees
Labels
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docsIssues/test failures with a fix SLA of 3 monthsSQL Foundations Team (formerly SQL Schema + SQL Sessions)Failures and bugs on the master branch.Used to mark GA and release blockers, technical advisories, and bugs for 23.2Used to mark GA and release blockers, technical advisories, and bugs for 24.1Used to mark GA and release blockers, technical advisories, and bugs for 24.2Used to mark GA and release blockers, technical advisories, and bugs for 24.3