Skip to content

roachtest: WaitForReady will never succeed if it times out the first time #136128

@andrewbaptist

Description

@andrewbaptist

Describe the problem

The function roachtestutil.WaitForReadyattempts to hit the health url on each of the nodes in the cluster to see if they are ready. However it has a 1 minute timeout, but after that is exceeded once it can never succeed since the context it uses for subsequent calls has already timed out.

We saw this in #136062. There is a different failure why it timed out the first time, but this code appears to retry but won't in this case.

Jira issue: CRDB-44899

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-kv-gossipC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-testengTestEng Teambranch-masterFailures and bugs on the master branch.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions