It's a common pattern to specify ServerArgs inside TestClusterArgs. If we specify Settings, this object ends up being shared between the nodes in the cluster. This can lead to very hard to debug failures, especially around updates to the version setting.
We should disallow having this field set in this way and fix up any tests that do this (one is here:
|
Settings: cluster.MakeTestingClusterSettingsWithVersions(endV, startV, false), |
).
Jira issue: CRDB-32395
It's a common pattern to specify
ServerArgsinsideTestClusterArgs. If we specifySettings, this object ends up being shared between the nodes in the cluster. This can lead to very hard to debug failures, especially around updates to the version setting.We should disallow having this field set in this way and fix up any tests that do this (one is here:
cockroach/pkg/kv/kvserver/client_migration_test.go
Line 251 in fbbf7ef
Jira issue: CRDB-32395