-
Notifications
You must be signed in to change notification settings - Fork 4.1k
server: regression in BenchmarkColBatchScan due to x-region, x-zone metrics #111148
Copy link
Copy link
Closed
Closed
Copy link
Labels
C-performancePerf of queries or internals. Solution not expected to change functional behavior.Perf of queries or internals. Solution not expected to change functional behavior.GA-blockerT-kvKV TeamKV Teambranch-release-23.2Used to mark GA and release blockers, technical advisories, and bugs for 23.2Used to mark GA and release blockers, technical advisories, and bugs for 23.2regressionRegression from a release.Regression from a release.
Description
Here is the impact of #104585 on BenchmarkColBatchScan from pkg/sql/colflow:
name old time/op new time/op delta
ColBatchScan/rows=16-24 72.5µs ± 5% 104.0µs ±14% +43.37% (p=0.000 n=10+10)
ColBatchScan/rows=256-24 172µs ± 9% 192µs ± 1% +11.55% (p=0.000 n=10+8)
ColBatchScan/rows=4096-24 1.40ms ± 1% 1.42ms ± 1% +1.78% (p=0.000 n=8+10)
ColBatchScan/rows=65536-24 21.5ms ± 1% 20.8ms ± 1% -3.24% (p=0.000 n=9+8)
name old speed new speed delta
ColBatchScan/rows=16-24 3.54MB/s ± 5% 2.48MB/s ±13% -29.82% (p=0.000 n=10+10)
ColBatchScan/rows=256-24 23.9MB/s ± 8% 21.3MB/s ± 1% -10.51% (p=0.000 n=10+8)
ColBatchScan/rows=4096-24 46.8MB/s ± 1% 46.0MB/s ± 1% -1.75% (p=0.000 n=8+10)
ColBatchScan/rows=65536-24 48.9MB/s ± 1% 50.5MB/s ± 1% +3.35% (p=0.000 n=9+8)
name old alloc/op new alloc/op delta
ColBatchScan/rows=16-24 8.34kB ±13% 8.65kB ± 4% ~ (p=0.266 n=10+8)
ColBatchScan/rows=256-24 27.9kB ± 0% 28.8kB ± 1% +3.03% (p=0.000 n=9+8)
ColBatchScan/rows=4096-24 195kB ±13% 192kB ± 0% ~ (p=0.114 n=8+9)
ColBatchScan/rows=65536-24 2.19MB ± 1% 2.23MB ±16% ~ (p=0.481 n=9+8)
name old allocs/op new allocs/op delta
ColBatchScan/rows=16-24 114 ±12% 118 ± 2% ~ (p=0.145 n=10+8)
ColBatchScan/rows=256-24 158 ± 0% 168 ± 1% +6.33% (p=0.000 n=7+8)
ColBatchScan/rows=4096-24 245 ±134% 207 ± 2% ~ (p=0.084 n=8+9)
ColBatchScan/rows=65536-24 321 ±46% 1826 ±382% ~ (p=0.474 n=9+9)
This issue seems similar to #111142.
Jira issue: CRDB-31790
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-performancePerf of queries or internals. Solution not expected to change functional behavior.Perf of queries or internals. Solution not expected to change functional behavior.GA-blockerT-kvKV TeamKV Teambranch-release-23.2Used to mark GA and release blockers, technical advisories, and bugs for 23.2Used to mark GA and release blockers, technical advisories, and bugs for 23.2regressionRegression from a release.Regression from a release.