-
Notifications
You must be signed in to change notification settings - Fork 4.1k
changefeedccl: improve test coverage for metrics #111042
Copy link
Copy link
Open
Labels
A-cdcChange Data CaptureChange Data CaptureC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-cdc
Description
There is not enough test coverage for metrics. Most of these SLI metrics have no test coverage.
- EmittedMessages changefeedccl: emittedmessages metric resolved messages semantics aren't consistent #111043
- FilteredMessages
- MessageSize
- EmittedBytes
- FlushedBytes
- BatchHistNanos
- Flushes
- FlushHistNanos
- SizeBasedFlushes
- ParallelIOQueueNanos
- SinkIOInflight
- CommitLatency
- ErrorRetries
- AdmitLatency
- BackfillCount
- BackfillPendingRanges
- RunningCount
- BatchReductionCount
- InternalRetryMessageCount
- [ ]
There likely isn't much test coverage for non-sli metrics either.
Jira issue: CRDB-31738
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-cdcChange Data CaptureChange Data CaptureC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-cdc