Skip to content

changefeedccl: improve test coverage for metrics #111042

@jayshrivastava

Description

@jayshrivastava

There is not enough test coverage for metrics. Most of these SLI metrics have no test coverage.

  • EmittedMessages changefeedccl: emittedmessages metric resolved messages semantics aren't consistent #111043
  • FilteredMessages
  • MessageSize
  • EmittedBytes
  • FlushedBytes
  • BatchHistNanos
  • Flushes
  • FlushHistNanos
  • SizeBasedFlushes
  • ParallelIOQueueNanos
  • SinkIOInflight
  • CommitLatency
  • ErrorRetries
  • AdmitLatency
  • BackfillCount
  • BackfillPendingRanges
  • RunningCount
  • BatchReductionCount
  • InternalRetryMessageCount
  • [ ]
    There likely isn't much test coverage for non-sli metrics either.

Jira issue: CRDB-31738

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-cdcChange Data CaptureC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-cdc

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions