-
Notifications
You must be signed in to change notification settings - Fork 4.1k
serverutils: flake in tests that use ALTER TENANT SET CLUSTER SETTING #110560
Copy link
Copy link
Closed
Copy link
Labels
A-multitenancyRelated to multi-tenancyRelated to multi-tenancyC-test-failureBroken test (automatically or manually discovered).Broken test (automatically or manually discovered).T-multitenantIssues owned by the multi-tenant virtual teamIssues owned by the multi-tenant virtual teamdb-cy-23
Description
Describe the problem
Found by @miretskiy in #110516:
=== RUN TestAlterChangefeedSwitchFamily/kafka
alter_changefeed_test.go:282: failed to start feed for job 0: pq: rangefeeds require the kv.rangefeed.enabled setting. See https://www.cockroachlabs.com/docs/v23.2/change-data-capture.html#enable-rangefeeds-to-reduce-latency
In a nutshell the test does this:
StartServer()ALTER TENANT ALL SET CLUSTER SETTING kv.rangefeed.enabled = truevia SQLStartTenant()
then the error happens when the test uses the tenant service.
The problem is that the setting override at step (2) has not yet propagated through the rangefeed when StartTenant is invoked.
Expected behavior
StartTenant should also restart the rangefeed on the setting overrides (currnetly it only restarts the rangefeed on the tenant metadata and capabilities).
Jira issue: CRDB-31506
Epic: CRDB-18499
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-multitenancyRelated to multi-tenancyRelated to multi-tenancyC-test-failureBroken test (automatically or manually discovered).Broken test (automatically or manually discovered).T-multitenantIssues owned by the multi-tenant virtual teamIssues owned by the multi-tenant virtual teamdb-cy-23