-
Notifications
You must be signed in to change notification settings - Fork 4.1k
cli/start: improper graceful drain upon stop trigger shutdown requests #108611
Copy link
Copy link
Closed
Labels
A-cli-serverCLI commands that pertain to CockroachDB server processesCLI commands that pertain to CockroachDB server processesA-server-start-drainPertains to server startup and shutdown sequencesPertains to server startup and shutdown sequencesC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.db-cy-23
Description
Describe the problem
The shutdown logic in cli/start tries graceful drains when receiving shutdown requests. This is incorrect; currently all shutdown reasons require non-graceful shutdowns.
Expected behavior
For all the current reasons the code in cli/start should use a non-graceful shutdown.
Epic: CRDB-28893
Jira issue: CRDB-30548
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-cli-serverCLI commands that pertain to CockroachDB server processesCLI commands that pertain to CockroachDB server processesA-server-start-drainPertains to server startup and shutdown sequencesPertains to server startup and shutdown sequencesC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.db-cy-23