kvserver: use of span after finish #108534
Description
On d9d421e when running ./dev test pkg/sql -f=TestRelocateNonVoters --stress --race --cpus=4 -- --test_env=COCKROACH_TEST_TENANT=true on the gceworker I got the following panic:
* ERROR: a panic has occurred!
* use of Span after Finish. Span: /cockroach.roachpb.Internal/Batch. Finish previously called at: <stack not captured. Set debugUseAfterFinish>
* (1) attached stack trace
* -- stack trace:
* | runtime.gopanic
* | › GOROOT/src/runtime/panic.go:890
* | [...repeated from below...]
* Wraps: (2) assertion failure
* Wraps: (3) attached stack trace
* -- stack trace:
* | github.com/cockroachdb/cockroach/pkg/util/tracing.(*Span).detectUseAfterFinish
* | › github.com/cockroachdb/cockroach/pkg/util/tracing/span.go:182
* | github.com/cockroachdb/cockroach/pkg/util/tracing.(*Span).RecordingType
* | › github.com/cockroachdb/cockroach/pkg/util/tracing/span.go:442
* | github.com/cockroachdb/cockroach/pkg/util/tracing.(*Span).IsVerbose
* | › github.com/cockroachdb/cockroach/pkg/util/tracing/span.go:450
* | github.com/cockroachdb/cockroach/pkg/util/log.getSpanOrEventLog
* | › github.com/cockroachdb/cockroach/pkg/util/log/trace.go:92
* | github.com/cockroachdb/cockroach/pkg/util/log.vEventf
* | › github.com/cockroachdb/cockroach/pkg/util/log/trace.go:212
* | github.com/cockroachdb/cockroach/pkg/util/log.VEvent
* | › github.com/cockroachdb/cockroach/pkg/util/log/trace.go:231
* | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*propBuf).FlushLockedWithRaftGroup
* | › github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/replica_proposal_buf.go:601
* | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).handleRaftReadyRaftMuLocked.func2
* | › github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/replica_raft.go:775
* | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).withRaftGroupLocked
* | › github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/replica_raft.go:1998
* | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).handleRaftReadyRaftMuLocked
* | › github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/replica_raft.go:772
* | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).handleRaftReady
* | › github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/replica_raft.go:728
* | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Store).processReady
* | › github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/store_raft.go:689
* | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*raftSchedulerShard).worker
* | › github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/scheduler.go:416
* | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*raftScheduler).Start.func2
* | › github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/scheduler.go:321
* | github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2
* | › github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:484
* | runtime.goexit
* | › src/runtime/asm_amd64.s:1594
* Wraps: (4) use of Span after Finish. Span: /cockroach.roachpb.Internal/Batch. Finish previously called at: <stack not captured. Set debugUseAfterFinish>
This logging seems to be added recently in 60b26ae.
Stack trace is here
Jira issue: CRDB-30511