-
Notifications
You must be signed in to change notification settings - Fork 4.1k
util/must: avoid circular dependencies #107427
Copy link
Copy link
Closed
Labels
A-testingTesting tools and infrastructureTesting tools and infrastructureC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-testengTestEng TeamTestEng Team
Description
Currently, must can't be used from packages that must itself depends on (e.g. util/log), due to circular depencies. If this is needed, we can solve it by dependency injection, where the necessary functions are injected into must global variables at runtime via init() calls. It isn't clear that we'll need it though, so let's not spend time on this until we do.
Jira issue: CRDB-30037
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-testingTesting tools and infrastructureTesting tools and infrastructureC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-testengTestEng TeamTestEng Team