tracing: additional goroutine per rangefeed

In 22.2, we see the number of goroutines per rangefeed increase from 4 to 5. The additional goroutine appears to be this:

```
1 @ 0x4907d6 0x4a071c 0x1653fb1 0x4c2401
# labels: {"dest_n":"1", "dest_r":"1012", "dest_s":"1", "distsql.gateway":"1", "f":"c975f0f6", "job":"883416806392332289", "n":"1"}
#	0x1653fb0	github.com/cockroachdb/cockroach/pkg/util/tracing/grpcinterceptor.newTracingClientStream.func2+0x70	github.com/cockroachdb/cockroach/pkg/util/tracing/grpcinterceptor/grpc_interceptor.go:340
```

Which comes from here:

https://github.com/cockroachdb/cockroach/blob/00fd3ef1fadde1d01f28a44d2bbeb65e3ba64f06/pkg/util/tracing/grpcinterceptor/grpc_interceptor.go#L348-L362

I believe this may have been introduced by #76306.

Jira issue: CRDB-29858

Epic CRDB-26372

	go func() {
	select {
	case <-finishChan:
	// The client span is being finished by another code path; hence, no
	// action is necessary.
	case <-ctx.Done():
	// A streaming RPC can be finished by the caller cancelling the ctx. If
	// the ctx is cancelled, the caller doesn't necessarily need to interact
	// with the stream anymore (see [1]), so finishChan might never be
	// signaled). Thus, we listen for ctx cancellation and finish the span.
	//
	// [1] https://pkg.go.dev/google.golang.org/grpc#ClientConn.NewStream
	finishFunc(nil /* err */)
	}
	}()

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tracing: additional goroutine per rangefeed #107053

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

tracing: additional goroutine per rangefeed #107053

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions