-
Notifications
You must be signed in to change notification settings - Fork 4.1k
StatementStatistics: improve lock contention performance #106789
Copy link
Copy link
Closed
Labels
A-cluster-observabilityRelated to cluster observabilityRelated to cluster observabilityC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Description
-
This lock for the stats object is taken for the rest of the method. The lock should be released here before the insights method is called.
-
Any computation like converting to string and getting the percentiles should be done before taking the lock to reduce the time the lock needs to be held.
-
Remove unnecessary set as it is part of the key.
Jira issue: CRDB-29716
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-cluster-observabilityRelated to cluster observabilityRelated to cluster observabilityC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)