Skip to content

kvserver: TestMergeQueueSeesLearnerOrJointConfig data race #105381

@erikgrinaker

Description

@erikgrinaker

Seen in a CI failure. Related to the recent replication AC work.

      WARNING: DATA RACE
      Write at 0x00c0086e4300 by goroutine 1927829:
        github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*RaftTransport).RaftMessageBatch.func2.1()
            github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/raft_transport.go:478 +0x1c5
        github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*RaftTransport).RaftMessageBatch.func2()
            github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/raft_transport.go:497 +0x84
        github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
            github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:484 +0x1f6
      
      Previous read at 0x00c0086e4300 by goroutine 1927828:
        github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*RaftTransport).RaftMessageBatch.func1()
            github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/raft_transport.go:455 +0x164
        runtime.deferreturn()
            GOROOT/src/runtime/panic.go:476 +0x32
        github.com/cockroachdb/cockroach/pkg/kv/kvserver._MultiRaft_RaftMessageBatch_Handler()
            github.com/cockroachdb/cockroach/pkg/kv/kvserver/bazel-out/k8-fastbuild/bin/pkg/kv/kvserver/kvserver_go_proto_/github.com/cockroachdb/cockroach/pkg/kv/kvserver/storage_services.pb.go:237 +0xc2
        github.com/cockroachdb/cockroach/pkg/util/tracing/grpcinterceptor.StreamServerInterceptor.func1()
            github.com/cockroachdb/cockroach/pkg/util/tracing/grpcinterceptor/grpc_interceptor.go:164 +0x679
        google.golang.org/grpc.chainStreamInterceptors.func1.1()
            google.golang.org/grpc/external/org_golang_google_grpc/server.go:1482 +0x105
        github.com/cockroachdb/cockroach/pkg/rpc.NewServerEx.func4()
            github.com/cockroachdb/cockroach/pkg/rpc/pkg/rpc/context.go:176 +0xe8
        google.golang.org/grpc.chainStreamInterceptors.func1.1()
            google.golang.org/grpc/external/org_golang_google_grpc/server.go:1485 +0x1e9
        github.com/cockroachdb/cockroach/pkg/rpc.kvAuth.streamInterceptor()
            github.com/cockroachdb/cockroach/pkg/rpc/pkg/rpc/auth.go:167 +0x556
        github.com/cockroachdb/cockroach/pkg/rpc.kvAuth.streamInterceptor-fm()
            <autogenerated>:1 +0xda
        google.golang.org/grpc.chainStreamInterceptors.func1.1()
            google.golang.org/grpc/external/org_golang_google_grpc/server.go:1485 +0x1e9
        github.com/cockroachdb/cockroach/pkg/rpc.NewServerEx.func2.1()
            github.com/cockroachdb/cockroach/pkg/rpc/pkg/rpc/context.go:143 +0x6f
        github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunTaskWithErr()
            github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:336 +0x147
        github.com/cockroachdb/cockroach/pkg/rpc.NewServerEx.func2()
            github.com/cockroachdb/cockroach/pkg/rpc/pkg/rpc/context.go:142 +0x14c
        google.golang.org/grpc.chainStreamInterceptors.func1.1()
            google.golang.org/grpc/external/org_golang_google_grpc/server.go:1485 +0x1e9
        google.golang.org/grpc.chainStreamInterceptors.func1()
            google.golang.org/grpc/external/org_golang_google_grpc/server.go:1487 +0x275
        google.golang.org/grpc.(*Server).processStreamingRPC()
            google.golang.org/grpc/external/org_golang_google_grpc/server.go:1636 +0x1ef5
        google.golang.org/grpc.(*Server).handleStream()
            google.golang.org/grpc/external/org_golang_google_grpc/server.go:1717 +0xfae
        google.golang.org/grpc.(*Server).serveStreams.func1.2()
            google.golang.org/grpc/external/org_golang_google_grpc/server.go:965 +0xec

Jira issue: CRDB-29008

Metadata

Metadata

Assignees

Labels

C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.C-test-failureBroken test (automatically or manually discovered).

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions