Skip to content

kvserver: refuse split keys for which DecodeTenantPrefix returns an error #104796

@tbg

Description

@tbg

Describe the problem

It's possible to create splits that send the nodes that have replicas of the right-hand side of the split into a crash loop.

We must verify all splits, even manual ones, on the validity of their split key.

See #104781 and internal issue https://github.com/cockroachlabs/support/issues/2382

NB: at time of writing it's not known which actor invoked the malformed split, but this is a separate issue.

To Reproduce

Look at/run the code in #104781 with the work-around commit reverted

Jira issue: CRDB-28730

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-kvKV Teamv23.1.4

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions