Currently, all of our upgrade unit tests (mostly logic tests outside of the cockroach-go config) bootstrap the cluster at V22_2. Since the release-23.1 branch has been cut, master should now be considered 23.2 work (#103551). As such, we should be writing our upgrade tests to bootstrap the cluster from V23_1.
This is made more complex in this release, as we intend to keep BinaryMinSupportedVersionKey at V22_2 in release-23.2 [1]. This means that, ideally, we should start testing our upgrades both from V22_2 and from V23_1.
This work will involve creating initial_values for the 23.1 release: see [2].
Assigning @cockroachdb/sql-foundations, as a lot of our upgrade tests are logic tests. Migration and tenant upgrade tests are also among tests that should be updated. Corrresponding teams are free to create separate issues to handle those changes.
[1] https://cockroachlabs.atlassian.net/wiki/spaces/RE/pages/2762309867/Version+Skipping+to+Enable+Long-Term+Support+LTS
[2]
|
var initialValuesFnByKey = map[Tenant]map[clusterversion.Key]initialValuesFn{ |
|
SystemTenant: { |
|
clusterversion.V22_2: initialValuesForSystemV222, |
|
}, |
|
SecondaryTenant: { |
|
clusterversion.V22_2: initialValuesForTenantV222, |
|
}, |
|
} |
Jira issue: CRDB-28269
Currently, all of our upgrade unit tests (mostly logic tests outside of the
cockroach-goconfig) bootstrap the cluster atV22_2. Since therelease-23.1branch has been cut, master should now be considered 23.2 work (#103551). As such, we should be writing our upgrade tests to bootstrap the cluster fromV23_1.This is made more complex in this release, as we intend to keep
BinaryMinSupportedVersionKeyatV22_2inrelease-23.2[1]. This means that, ideally, we should start testing our upgrades both fromV22_2and fromV23_1.This work will involve creating initial_values for the 23.1 release: see [2].
Assigning @cockroachdb/sql-foundations, as a lot of our upgrade tests are logic tests. Migration and tenant upgrade tests are also among tests that should be updated. Corrresponding teams are free to create separate issues to handle those changes.
[1] https://cockroachlabs.atlassian.net/wiki/spaces/RE/pages/2762309867/Version+Skipping+to+Enable+Long-Term+Support+LTS
[2]
cockroach/pkg/sql/catalog/bootstrap/initial_values.go
Lines 76 to 83 in bc6b056
Jira issue: CRDB-28269