-
Notifications
You must be signed in to change notification settings - Fork 4.1k
kvserver: make probe request application cheap #103905
Copy link
Copy link
Closed
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.v23.1.9
Description
NoopRequest should be the cheapest raft command to apply (since it's deterministically rejected below raft, i.e. only writes the LeaseAppliedState update) but accidentally it wasn't marked as a trivial ("batchable") command. We think this wildly inflates the cost of applying such a command, as seen in https://github.com/cockroachlabs/support/issues/2287.
We should fix this.
x-ref #102953
Jira issue: CRDB-28253
Epic CRDB-25287
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.v23.1.9