Skip to content

cpuprofiler: remove server.cpu_profile.enabled setting #102024

@tbg

Description

@tbg

Describe the problem

From 23.1 testcluster. We had high CPU usage for a couple of hours under the following cluster setting

root@localhost:26257/defaultdb> show cluster setting server.cpu_profile.cpu_usage_combined_threshold;
  server.cpu_profile.cpu_usage_combined_threshold
---------------------------------------------------
                                               75
(1 row)

but no profiles were taken. It took me a couple of hours to realize the obvious - I hadn't also set server.cpu_profile.enabled. This caught me by surprise because the combined_threshold description also allows disabling (by setting to a value > 100).

We should remove the .enabled setting. It's confusing to have two ways to disable/enable this.

Jira issue: CRDB-27225

Metadata

Metadata

Assignees

Labels

C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.O-testclusterIssues found or occurred on a test cluster, i.e. a long-running internal cluster

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions