-
Notifications
You must be signed in to change notification settings - Fork 4.1k
upgrades: upgrades don't seem to run when developmentBranch is set to false #100685
Copy link
Copy link
Closed
Closed
Copy link
Labels
A-jobsC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-jobsbranch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.branch-release-23.1Used to mark GA and release blockers, technical advisories, and bugs for 23.1Used to mark GA and release blockers, technical advisories, and bugs for 23.1release-blockerIndicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Description
When manually modifying developmentBranch (as in #99387) a couple of tests[1] fail.
For example:
--- FAIL: TestServerStartupGuardrails (0.23s)
test_server_shim.go:353: migration-manager-find-jobs: system-jobs-scan: relation "system.job_info" does not exist
This suggests that we are not properly running the SQL migrations in that case.
[1] Tests that fail:
- TestAlreadyRunningJobsAreHandledProperly, TestPauseMigration - fixed by release-23.1: upgrademanager: fix upgrade manager tests that relied on wrong invariants #100867
- TestServerStartupGuardrails - fixed by release-23.1: serverccl: conditionally apply DevOffset in TestServerStartupGuardrails #100729
Jira issue: CRDB-26555
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-jobsC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-jobsbranch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.branch-release-23.1Used to mark GA and release blockers, technical advisories, and bugs for 23.1Used to mark GA and release blockers, technical advisories, and bugs for 23.1release-blockerIndicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.