Override query_conditions_for_initial_load#182
Merged
rafiss merged 1 commit intocockroachdb:masterfrom Mar 5, 2021
Merged
Conversation
Contributor
|
Excellent! This looks good, will just wait for the tests to pass. I checked on Postgres, and it looks like the original query only returns one extra row compared to the new query: This is the "tuple array" type, and it looks like it has a typcategory of P (pseudotype) instead of A (array) in PostgreSQL. I don't think this detail matters that much. |
rafiss
approved these changes
Mar 5, 2021
This was referenced Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overrides the
TypeMapInitializer#query_conditions_for_initial_loadmethod to use a faster query that doesn't rely on'array_in(cstring,oid,integer)'::regprocedure.That part of the condition can be replaced with
This can be verified by comparing the following queries:
the second query is about 10x faster for me.
A potential issue is that these do not return the same results in Postgres (a few records are missing from the second) so the queries could eventually diverge depending on updates to Cockroach.
This is related to cockroachdb/cockroach#61082.