Fix test environment setup and build system issues#546
Merged
greghaynes merged 3 commits intomainfrom Dec 19, 2025
Merged
Conversation
Co-authored-by: jessesanford <108698+jessesanford@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] I would like you to run all the tests and make sure that they all run correctly and that all packages can be built successfully I believe that there are some errors around the use of older Docker APIs and possibly some issues with KIND as well.
Fix test environment setup and build system issues
Sep 11, 2025
Contributor
|
why did you modify pkg/controllers/localbuild/resources/gitea/k8s/install.yaml @copilot ? |
Co-authored-by: jessesanford <108698+jessesanford@users.noreply.github.com>
Contributor
Author
You're absolutely right to question this. That modification was accidental and not related to the issues I was fixing. I've reverted the file back to its original state in commit 163c2f7. The gitea install.yaml file now contains all the original Kubernetes manifests as it should. |
greghaynes
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-p 1and--tags=integration)Issues Fixed
1. Integration Test Failures
The integration tests in
pkg/controllers/custompackagewere failing because the envtest environment couldn't locate the required Kubernetes binaries. The tests were looking foretcd,kube-apiserver, andkubectlbinaries but they weren't being installed properly.Root Cause: The
KUBEBUILDER_ASSETSenvironment variable wasn't being set correctly, and the envtest binaries weren't being downloaded.Solution: Fixed the envtest setup to properly download and configure the Kubernetes test binaries at the expected location (
bin/k8s/1.29.1-linux-amd64/).2. Makefile Syntax Error
There was a syntax error in the Makefile's test target on line 43 where a space was missing between
-p 1and--tags=integration.3. Accidental File Modification
Reverted an accidental modification to
pkg/controllers/localbuild/resources/gitea/k8s/install.yamlthat was not related to the core issues being fixed.Test Results
After these fixes:
make buildsucceeds)The repository is now in a fully functional state with all tests passing and builds working correctly.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.