fix: Fixed a bug where the ArgoCD Kustomization created duplicate argocd-rbac-cm resources#516
Conversation
…ocd-rbac-cm resources Signed-off-by: Luis Schweigard <luis.schweigard@gmail.com>
|
/e2e |
|
@lieberlois Thanks for this! Would you mind fixing the test as well? It was updated to 59 when the manifest was updated but it should be 58 like you mentioned. |
|
@nabuskey Sure, I'll get to it tomorrow! Just curious whether you think this test is actually useful? Personally I think we are more or less just testing Kustomize here - either way, I'll get to it tomorrow! |
IMO it's not really useful. The test needs to actually validate contents of the manifests. I am ok with removing it. If you do remove it, could you open an issue to track it? |
|
I'll look into it tomorrow @nabuskey - just wanted to mention my concern here that the test (even if it would validate the contents) doesn't really test idpbuilder but rather ArgoCD Kustomizations or even Kustomize itself. It would be a different story if the test would cover custom overlays (e.g. custom ArgoCD config) applied from idpbuilder - but I'm not even sure if that is possible ^^ |
Signed-off-by: Luis Schweigard <luis.schweigard@gmail.com>
|
@nabuskey I adjusted the test from 59 to 58 for now since changing the test setup should not be part of this PR. If you want we can discuss this further, but I'd like to get this fixed ASAP since I need it for a workshop 😉 |
I think we need to add this kind of tests to e2e. Ensure our core components run with no errors. Right now, we don't really test that. We just test that they are healthy and synced. |
Resolves #515 by properly patching the existing argocd-rbac-cm.