Skip to content

fix bugs around kube config path flags#497

Merged
punkwalker merged 1 commit intocnoe-io:mainfrom
squidboylan:kube-config-package-get
Mar 27, 2025
Merged

fix bugs around kube config path flags#497
punkwalker merged 1 commit intocnoe-io:mainfrom
squidboylan:kube-config-package-get

Conversation

@squidboylan
Copy link
Copy Markdown
Contributor

@squidboylan squidboylan commented Mar 9, 2025

This centralizes the GetKubeClient and GetKubeConfig functions so that we're always using the right kube config path

@squidboylan
fix bugs around kube config path flags
0a666b1 
This centralizes the GetKubeClient and GetKubeConfig functions so that
we're always using the right kube config path

Signed-off-by: Caleb Boylan <calebboylan@gmail.com>
@punkwalker
Copy link
Copy Markdown
Contributor

punkwalker commented Mar 12, 2025

Thank you @squidboylan for working on this. This LGTM. Only small query: Would this fix #362 as well?

@squidboylan
Copy link
Copy Markdown
Contributor Author

squidboylan commented Mar 12, 2025

Would this fix #362 as well?

I dont think so, this only fixes the --kubeconfig flag for the get * commands, the create command still doesn't have that flag. This change does get us closer to being able to support that flag though as it should reduce some of the duplicate code that generates the kubeconfig path and builds a kube client. I can probably take a look at fixing that issue sometime soon.

@punkwalker
Copy link
Copy Markdown
Contributor

punkwalker commented Mar 12, 2025

Would this fix #362 as well?

I dont think so, this only fixes the --kubeconfig flag for the get * commands, the create command still doesn't have that flag. This change does get us closer to being able to support that flag though as it should reduce some of the duplicate code that generates the kubeconfig path and builds a kube client. I can probably take a look at fixing that issue sometime soon.

Great. Meanwhile, we can merge this one. Thanks for confirming.

@punkwalker
Copy link
Copy Markdown
Contributor

punkwalker commented Mar 12, 2025

/e2e

punkwalker
punkwalker approved these changes Mar 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@punkwalker punkwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

@punkwalker punkwalker merged commit f604b8a into cnoe-io:main Mar 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@punkwalker punkwalker punkwalker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@squidboylan @punkwalker