Skip to content

error out when configurations do not match#418

Merged
nabuskey merged 2 commits intocnoe-io:mainfrom
nabuskey:fail-early
Oct 17, 2024
Merged

error out when configurations do not match#418
nabuskey merged 2 commits intocnoe-io:mainfrom
nabuskey:fail-early

Conversation

@nabuskey
Copy link
Copy Markdown
Collaborator

@nabuskey nabuskey commented Oct 17, 2024 •
edited
Loading

fixes: #416

if a cluster was created with a configuration, then a different configuration is passed for the same cluster, error out.

./idpbuilder create

./idpbuilder create --use-path-routing
Oct 17 20:39:41 INFO Creating kind cluster logger=setup
Oct 17 20:39:41 INFO Runtime detected logger=setup provider=docker
Oct 17 20:39:41 INFO Cluster already exists logger=setup cluster=localdev
Oct 17 20:39:41 INFO Adding CRDs to the cluster logger=setup
Oct 17 20:39:41 INFO Setting up CoreDNS logger=setup
Oct 17 20:39:41 INFO Setting up TLS certificate logger=setup
Oct 17 20:39:41 ERROR Error while checking incompatible flags logger=setup err=provided command flags and existing configurations are incompatible. please recreate the cluster. existing: {Protocol:https Host:cnoe.localtest.me IngressHost:cnoe.localtest.me Port:8443 UsePathRouting:false SelfSignedCert:}, given: {Protocol:https Host:cnoe.localtest.me IngressHost:cnoe.localtest.me Port:8443 UsePathRouting:true SelfSignedCert:}
Error: :provided command flags and existing configurations are incompatible. please recreate the cluster. existing: {Protocol:https Host:cnoe.localtest.me IngressHost:cnoe.localtest.me Port:8443 UsePathRouting:false SelfSignedCert:}, given: {Protocol:https Host:cnoe.localtest.me IngressHost:cnoe.localtest.me Port:8443 UsePathRouting:true SelfSignedCert:}

@nabuskey
error out when configurations do not match
4cd0257 
Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
@nabuskey
update comment
971f192 
Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
@nabuskey nabuskey requested a review from blakeromano October 17, 2024 20:42
blakeromano
blakeromano reviewed Oct 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@blakeromano blakeromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good just some questions about types we are choosing

api/v1alpha1/localbuild_types.go
Host string `json:"host,omitempty"`
IngressHost string `json:"ingressHost,omitempty"`
Port string `json:"port,omitempty"`
UsePathRouting bool `json:"usePathRouting,omitempty"`
Copy link
Copy Markdown
Contributor

@blakeromano blakeromano Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean maybe a nit but do we ever expect to have other kind of routing where we want to make this an enum string?

Copy link
Copy Markdown
Collaborator Author

@nabuskey nabuskey Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I honestly cannot think of other ways to route for now. Maybe this is something we can take a look at later along with the potential changes to the name of the flag. #417

@nabuskey nabuskey merged commit edaa249 into cnoe-io:main Oct 17, 2024
@nabuskey nabuskey deleted the fail-early branch October 17, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeromano blakeromano blakeromano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refuse to run when incomatible settings are used

2 participants

@nabuskey @blakeromano