Skip to content

fix gitea registry for path based routing#411

Merged
nabuskey merged 1 commit intocnoe-io:mainfrom
nabuskey:gitea-registry
Oct 17, 2024
Merged

fix gitea registry for path based routing#411
nabuskey merged 1 commit intocnoe-io:mainfrom
nabuskey:gitea-registry

Conversation

@nabuskey
Copy link
Copy Markdown
Collaborator

@nabuskey nabuskey commented Oct 15, 2024

fixes: #410
fixes: #344

Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
Copy link
Copy Markdown
Contributor

@cmoulliard cmoulliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the parameter that we are using here: use-path-routing is not meaningful as in fact it allows the user to configure the internal container registry using either the FQDN of gitea or the domain name.

I suggest to rename it to something like no-fqdn

By the way, the documentation should be reviewed to detail what idp do when this parameter/Argument is selected !!

@nabuskey
Copy link
Copy Markdown
Collaborator Author

The name of the parameter that we are using here: use-path-routing is not meaningful as in fact it allows the user to configure the internal container registry using either the FQDN of gitea or the domain name.

I suggest to rename it to something like no-fqdn

By the way, the documentation should be reviewed to detail what idp do when this parameter/Argument is selected !!

We can revisit the flag name in the future for sure. We do need to illustrate what the flag does too.

Copy link
Copy Markdown
Contributor

@blakeromano blakeromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think before we release we need some protection on if cluster was created with path based routing and I create with host based routing on the second run that we should log an error or some sort of indication that hey we are doing something wrong or this requires to be recreated...

Talking with Manabu on slack I think we are in agreement that as long as both this and that are in the same release I am fine with approving this

@nabuskey
Copy link
Copy Markdown
Collaborator Author

Opened #416 to track what Blake said.

@nabuskey nabuskey merged commit d966372 into cnoe-io:main Oct 17, 2024
@nabuskey nabuskey deleted the gitea-registry branch October 17, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Kind cannot pull container images from gitea when using path based routing Add gitea registry tests

3 participants