Merged
Conversation
Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
Contributor
|
What is the duration of the |
Collaborator
Author
No expiration. I don't think Gitea supports it until they move to JWT: go-gitea/gitea#4793 |
cmoulliard
reviewed
Oct 7, 2024
Contributor
cmoulliard
left a comment
There was a problem hiding this comment.
Could also mention within the documentation that we generate a gitea token having full AdminScope to manage: repository, issues, packages, etc and that a user could use it to query the API as documented here: https://docs.gitea.com/next/development/api-usage#more-on-the-authorization-header ?
blakeromano
approved these changes
Oct 7, 2024
Contributor
blakeromano
left a comment
There was a problem hiding this comment.
Looks fine as is. Just one small comment
| KeepAlive: 30 * time.Second, // from http.DefaultTransport | ||
| }).DialContext, | ||
| } | ||
| return &http.Client{Transport: tr, Timeout: 30 * time.Second} |
Contributor
There was a problem hiding this comment.
This timeout seems really long but maybe I am misunderstanding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes idpbuilder generate a Gitea admin token. This is useful for use cases such as:
Partially fixes: #378
Example output: