Skip to content

use kind labels field#376

Merged
nabuskey merged 2 commits intocnoe-io:mainfrom
nabuskey:ingress-label
Aug 29, 2024
Merged

use kind labels field#376
nabuskey merged 2 commits intocnoe-io:mainfrom
nabuskey:ingress-label

Conversation

@nabuskey
Copy link
Copy Markdown
Collaborator

fixes: #374

Copy link
Copy Markdown
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani
Copy link
Copy Markdown
Contributor

you missed DCO it seems

Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
@nabuskey nabuskey merged commit eab34d6 into cnoe-io:main Aug 29, 2024
@nabuskey nabuskey deleted the ingress-label branch August 29, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the default kind cluster config for ingress-nginx label

2 participants