Add substitution for aarch64 to installation bash script#363
Merged
nimakaviani merged 1 commit intocnoe-io:mainfrom Aug 26, 2024
Merged
Add substitution for aarch64 to installation bash script#363nimakaviani merged 1 commit intocnoe-io:mainfrom
nimakaviani merged 1 commit intocnoe-io:mainfrom
Conversation
Collaborator
|
@nimakaviani Please review. |
Contributor
|
LGTM. can you please sign the DCO? thanks! |
On some ARM64 Linux instances, `uname -m` returns `aarch64` instead of `arm64`. This causes the installation script to fail. This change adds an additional substitution for this scenario Signed-off-by: Andrew Rosca <andrew@rosca.net>
Contributor
Author
|
@nimakaviani done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some ARM64 Linux instances,
uname -mreturnsaarch64instead ofarm64. This causes the installation script to fail.This change adds an additional substitution for this scenario