Merged
Conversation
Signed-off-by: AryanSharma9917 <sharmaaryan9837@gmail.com>
Contributor
Author
|
@nabuskey could you please review my PR? |
nabuskey
requested changes
Aug 16, 2024
Collaborator
nabuskey
left a comment
There was a problem hiding this comment.
Thank you very much for this! I think the go mod file need changes but otherwise looks good.
go.mod
Outdated
| module github.com/cnoe-io/idpbuilder | ||
|
|
||
| go 1.21.3 | ||
| go 1.22 |
Collaborator
There was a problem hiding this comment.
I think this needs to be 1.22.0 because that's the minimum required by K8s v0.30.0+.
Signed-off-by: AryanSharma9917 <sharmaaryan9837@gmail.com>
d44f896 to
8e193b6
Compare
nabuskey
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses Issue #259 by updating the Go version from 1.21 to 1.22. The following changes have been made:
idpbuilder/go.modto 1.22..github/workflows/e2e.yaml,.github/workflows/pr.yaml, and.github/workflows/release.yamlto use Go version 1.22.These changes are necessary to support the upgrade to Kubernetes 1.30, which requires Go 1.22.