Skip to content

skip refresh if owned by app set#354

Merged
nimakaviani merged 1 commit intocnoe-io:mainfrom
nabuskey:selective-refresh
Aug 5, 2024
Merged

skip refresh if owned by app set#354
nimakaviani merged 1 commit intocnoe-io:mainfrom
nabuskey:selective-refresh

Conversation

@nabuskey
Copy link
Copy Markdown
Collaborator

@nabuskey nabuskey commented Aug 5, 2024

On exit, we currently refresh ALL ArgoCD Applications. If applications are owned by application sets, we should not refresh them ourselves. Let ApplicationSets refresh instead.

Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
Copy link
Copy Markdown
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit a22d504 into cnoe-io:main Aug 5, 2024
@nabuskey nabuskey deleted the selective-refresh branch August 6, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants