Merged
Conversation
Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
Contributor
|
Thanks @nabuskey I think this fix the issue I posted. I'm ok not having the functionality to replace everywhere for now. Maybe we can wait to see if someone asks for it, and even then we can put behind a experimental env variable to allow it. |
csantanapr
approved these changes
Jul 20, 2024
blakeromano
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #339
With this PR we now look at the
helmValueObjectfield in ArgoCD applications.I ended up implementing a general replacement function that could be used for any field in ArgoCD application spec to replace
cnoe://with derived git URL. This functionality is not enabled in this PR however. I am not sure if this is something we want to support.