Skip to content

support matrix git generator#338

Merged
nimakaviani merged 1 commit intocnoe-io:mainfrom
nabuskey:support-matrix-generator
Jul 10, 2024
Merged

support matrix git generator#338
nimakaviani merged 1 commit intocnoe-io:mainfrom
nabuskey:support-matrix-generator

Conversation

@nabuskey
Copy link
Copy Markdown
Collaborator

ApplicationSet has a generator called matrix generator: https://argo-cd.readthedocs.io/en/stable/operator-manual/applicationset/Generators-Matrix/

This can embed other generators like the git generator. We need to support it for use cases where parameter values are pulled from git.

Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
@nabuskey nabuskey requested review from a team July 10, 2024 22:07
Copy link
Copy Markdown
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit 8099edd into cnoe-io:main Jul 10, 2024
@nabuskey nabuskey deleted the support-matrix-generator branch July 11, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants