Skip to content

ensure latest stable version is downloaded#332

Merged
nabuskey merged 1 commit intocnoe-io:mainfrom
nabuskey:fix-install-script
Jul 8, 2024
Merged

ensure latest stable version is downloaded#332
nabuskey merged 1 commit intocnoe-io:mainfrom
nabuskey:fix-install-script

Conversation

@nabuskey
Copy link
Copy Markdown
Collaborator

@nabuskey nabuskey commented Jul 5, 2024

Right now, the install script and the install instructions downloads the latest nightly release. This is not what we want. We want users to use the latest stable version.

Currently:

version=$(curl -Ls -o /dev/null -w %{url_effective} https://github.com/cnoe-io/idpbuilder/releases/latest)
version=${version##*/}
echo $version
v0.6.0-nightly.20240705

With this PR:

version=$(curl -s https://api.github.com/repos/cnoe-io/idpbuilder/releases | grep tag_name | grep -o -e '"v[0-9].[0-9].[0-9]"' | head -n1 | sed 's/"//g')
echo $version
v0.5.0

@nabuskey
ensure latest stable version is downloaded
e0ff801 
Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
@nabuskey nabuskey requested a review from a team as a code owner July 5, 2024 17:04
@nabuskey nabuskey requested a review from a team July 5, 2024 17:05
omrishiv
omrishiv approved these changes Jul 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@omrishiv omrishiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nabuskey nabuskey merged commit dd3b226 into cnoe-io:main Jul 8, 2024
@nabuskey nabuskey deleted the fix-install-script branch July 8, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omrishiv omrishiv omrishiv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nabuskey @omrishiv