use internally and externally resolvable git url#326
Merged
nimakaviani merged 1 commit intocnoe-io:mainfrom Jun 22, 2024
Merged
use internally and externally resolvable git url#326nimakaviani merged 1 commit intocnoe-io:mainfrom
nimakaviani merged 1 commit intocnoe-io:mainfrom
Conversation
Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently argocd applications are synced to gitea repositories by using the internal service URLs like
http://my-gitea-http.gitea.svc.cluster.local:3000. This PR changes the behaviour to use the now internally resolvable URL instead. Users can now use the URL given in the Gitea UI to configure ArgoCD.