Enable code/dependency scanning#323
Merged
nabuskey merged 4 commits intocnoe-io:mainfrom Jun 21, 2024
Merged
Conversation
Signed-off-by: omrishiv <327609+omrishiv@users.noreply.github.com>
Signed-off-by: omrishiv <327609+omrishiv@users.noreply.github.com>
Contributor
Author
|
Fixes #135 |
nabuskey
reviewed
Jun 21, 2024
.github/workflows/code-scanner.yaml
Outdated
| path: "." | ||
|
|
||
| - name: Upload scan results to GitHub Security tab | ||
| uses: github/codeql-action/upload-sarif@v2 |
Collaborator
There was a problem hiding this comment.
This is deprecated. We need to update. https://github.com/cnoe-io/idpbuilder/actions/runs/9605967327/job/26494616601?pr=323
Signed-off-by: omrishiv <327609+omrishiv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I addressed all the security issues in the dependencies in #294 so this is currently not reporting anything. I guess we wait until the next one?