Add Package Flag and Mark Package-Dir as Deprecated#309
Merged
nimakaviani merged 2 commits intocnoe-io:mainfrom Jun 18, 2024
Merged
Add Package Flag and Mark Package-Dir as Deprecated#309nimakaviani merged 2 commits intocnoe-io:mainfrom
nimakaviani merged 2 commits intocnoe-io:mainfrom
Conversation
Signed-off-by: Blake R <85771645+blakeromano@users.noreply.github.com>
nimakaviani
requested changes
Jun 18, 2024
Contributor
nimakaviani
left a comment
There was a problem hiding this comment.
This looks great, thank you. There are also a number of places in the README documentation where we refer to the deprecated package. can you please fix them with this PR?
In particular, in both cases where we have -p or --package-dir, we should rename them to --package.
thank you!
This was referenced Jun 18, 2024
nimakaviani
reviewed
Jun 18, 2024
Signed-off-by: Blake R <85771645+blakeromano@users.noreply.github.com>
Contributor
Author
|
I think I addressed all the PR comments but feel free to let me know if I am missing anything 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves: #264
One thing I didn't know if we wanted to do it in this PR is to setup the skeleton for supporting non-local packages like noted in this comment: #264 (comment) I thought that fell out of the scope of the ask in the issue but I am happy to establish that start if it is better to do it in this PR.