ensure core package customizations are processed#307
Merged
nimakaviani merged 1 commit intocnoe-io:mainfrom Jun 17, 2024
Merged
ensure core package customizations are processed#307nimakaviani merged 1 commit intocnoe-io:mainfrom
nimakaviani merged 1 commit intocnoe-io:mainfrom
Conversation
Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
ffa6c94 to
65f561d
Compare
blakeromano
reviewed
Jun 17, 2024
Contributor
blakeromano
left a comment
There was a problem hiding this comment.
I also don't really see much documentation around how this feature is supposed to be invoked/used...
Is this a CLI argument to idpbuilder create?
| description: FilePath is the absolute file path to a YAML | ||
| file that contains Kubernetes manifests. | ||
| type: string | ||
| name: |
Contributor
There was a problem hiding this comment.
Can we make this an enum?
| description: PackageCustomization defines how packages are customized | ||
| properties: | ||
| filePath: | ||
| description: FilePath is the absolute file path to a YAML |
Contributor
There was a problem hiding this comment.
is the plan to not support helm or kustomize?
Contributor
|
Good catch on the labels @nabuskey |
nimakaviani
approved these changes
Jun 17, 2024
Collaborator
Author
We do need to do a better job of documenting these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #298
One thing to note when overwriting argocd CMs is that you need to have the labels on the CM. Otherwise, ArgoCD will complain about not finding
argocd-cmCM.@csantanapr ^^