Skip to content

ensure only yaml files are processed#288

Merged
nimakaviani merged 1 commit intocnoe-io:mainfrom
nabuskey:fix/file-type-check
Jun 11, 2024
Merged

ensure only yaml files are processed#288
nimakaviani merged 1 commit intocnoe-io:mainfrom
nabuskey:fix/file-type-check

Conversation

@nabuskey
Copy link
Copy Markdown
Collaborator

We should be looking at yaml files only when processing custom packages.

@nimakaviani
Copy link
Copy Markdown
Contributor

looks like there is a failing test that needs fixing

Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
@nabuskey nabuskey force-pushed the fix/file-type-check branch from 0393081 to 2d2fba5 Compare June 11, 2024 16:08
@nabuskey
Copy link
Copy Markdown
Collaborator Author

@nimakaviani Fixed.

@nimakaviani nimakaviani self-requested a review June 11, 2024 17:07
Copy link
Copy Markdown
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit 5e4aca7 into cnoe-io:main Jun 11, 2024
@nabuskey nabuskey deleted the fix/file-type-check branch June 12, 2024 02:03
@cmoulliard
Copy link
Copy Markdown
Contributor

Can you next time please create a ticket otherwise it is needed to look to the issues and/or PR to discover; bug fixed, enhancements, etc @nabuskey @nimakaviani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants