Skip to content

remove html escape#284

Merged
nimakaviani merged 1 commit intocnoe-io:mainfrom
nabuskey:get-encoding
Jun 6, 2024
Merged

remove html escape#284
nimakaviani merged 1 commit intocnoe-io:mainfrom
nabuskey:get-encoding

Conversation

@nabuskey
Copy link
Copy Markdown
Collaborator

@nabuskey nabuskey commented Jun 6, 2024

As mentioned by @cmoulliard in #283 , the get secret json output escapes certain special characters. This behaviour is not desirable for our purposes.

https://pkg.go.dev/encoding/json#Encoder.SetEscapeHTML

Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
@nimakaviani nimakaviani self-requested a review June 6, 2024 18:30
Copy link
Copy Markdown
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit 4a972e3 into cnoe-io:main Jun 6, 2024
@nabuskey nabuskey deleted the get-encoding branch June 11, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants