remove problematic special chars for bash#276
Merged
nimakaviani merged 1 commit intocnoe-io:mainfrom Jun 4, 2024
Merged
Conversation
Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
Contributor
|
Backstage is complaining too about the |
Contributor
|
sorry I missed the context on this one when I merged it. Only saw the slack conversation afterwards. Should have let @cmoulliard review it first. Anyway, we will have to get the fix in for the latest issue with Backstage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using idpbuilder with bash, the gitea secret could contain special characters that are not user or bash friendly. Especially in bash scripts, special characters often have meaning. Removing the following characters:
",\.Ref: https://cloud-native.slack.com/archives/C05TN9WFN5S/p1717410133645919