enable serverside apply for tf-controller install#249
Merged
Conversation
fixes The ConfigMap is invalid: metadata.annotations: Too long when installing the controller Signed-off-by: Nima Kaviani <nkaviani@amazon.com>
Contributor
|
This issue was intermittent for me and not consistent but thanks for this fix. |
Collaborator
|
I've run into this issue before too. I think the fix for me was to use the replace option but it comes with some serious drawbacks. if SSA fixes it, I'm all for it. |
Contributor
Author
|
yeah based on all the discussion in the issue I linked you can use eitehr |
nabuskey
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
The ConfigMap is invalid: metadata.annotations: Too longissue when installing the tf-controller.Also bumps the version of the tofu controller
The problem is discussed in details here: argoproj/argo-cd#820 and the issue suggests to use
ServerSideApply=trueto skip the use of Kubectl when applying resources./cc @elamaran11