feat:add embedded-resources target in Makefile#233
Merged
nabuskey merged 2 commits intocnoe-io:mainfrom May 1, 2024
Merged
Conversation
resolve cnoe-io#136 Signed-off-by: iron87 <fede.cerruto@gmail.com>
nabuskey
reviewed
Apr 30, 2024
Collaborator
nabuskey
left a comment
There was a problem hiding this comment.
Thank you very much for this PR!
I don't think I was specific enough in the issue. That's my bad. Instead of embedding bash scripts in the Makefile, let's create a script in the hack directory so that it's easier to edit in the future. In the script we should specify directory names since we know which directories we care about. Something like this:
hack/embedded-resources.sh
#!/bin/bash
for dir in argo-cd gitea ingress-nginx; do
./hack/$dir/generate-manifests.sh;
if [[ $? -ne 0 ]]; then
echo "error running script: ./hack/$dir/generate-manifests.sh"
exit 1
fi
done
Then we can run it like so in Makefile:
.PHONY: embedded-resources
embedded-resources:
./hack/embedded-resources.shSigned-off-by: iron87 <fede.cerruto@gmail.com>
nabuskey
approved these changes
May 1, 2024
Collaborator
nabuskey
left a comment
There was a problem hiding this comment.
LGTM. Thank you very much for this PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #136