fix recreate flag behavior when using finch#185
Merged
nimakaviani merged 4 commits intomainfrom Apr 29, 2024
Merged
Conversation
Contributor
|
This looks like a reasonable approach to me |
nabuskey
reviewed
Apr 11, 2024
a48a21c to
9457f27
Compare
c82b3bf to
bd083d4
Compare
nabuskey
reviewed
Apr 25, 2024
- abstracting the runtime provider - implementing the runtime both for finch and docker - using the finch cli for container creation Signed-off-by: Nima Kaviani <nkaviani@amazon.com>
Signed-off-by: Nima Kaviani <nkaviani@amazon.com>
- respect KIND_EXPERIMENTAL_PROVIDER Signed-off-by: Nima Kaviani <nkaviani@amazon.com>
Signed-off-by: Nima Kaviani <nkaviani@amazon.com>
bd083d4 to
209cf8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nabuskey
@greghaynes
@estesp
@csantanapr
appreciate a review on the above. Also, @estesp curious if there is a more elegant way than using the Finch CLI for the implementation, but ideally without the need to pull in containerd stuff.