Closed
Conversation
Contributor
|
Can you please add an issue with the description about the PR ? |
Contributor
|
@cmoulliard, I believe this is the issue the PR is for: #161 |
nimakaviani
requested changes
Mar 26, 2024
| metadata: | ||
| annotations: | ||
| controller-gen.kubebuilder.io/version: v0.14.0 | ||
| controller-gen.kubebuilder.io/version: v0.12.0 |
Contributor
There was a problem hiding this comment.
looks like you need to bump the version of your controller gen. are you using an older version of idpbuilder or is there any other reason to have this older version used?
Comment on lines
-22
to
+24
| description: |- | ||
| APIVersion defines the versioned schema of this representation of an object. | ||
| Servers should convert recognized schemas to the latest internal value, and | ||
| may reject unrecognized values. | ||
| More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources | ||
| description: 'APIVersion defines the versioned schema of this representation | ||
| of an object. Servers should convert recognized schemas to the latest | ||
| internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources' |
Contributor
There was a problem hiding this comment.
these diffs will go away if a newer version of controller gen is used
Comment on lines
+14
to
+16
| type KindConfig struct { | ||
| KindConfigPath string | ||
| } |
Contributor
There was a problem hiding this comment.
better to move the KindConfig definition under pkg/k8s/providers/kind for it to be self contained
Collaborator
|
Closing this due to inactivity. Feel free to reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.