Use cc_test from rules_cc instead of native.cc_test#129
Merged
Conversation
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Contributor
Author
|
/cc @adisuissa , @phlax , envoyproxy/envoy#42214 validates this PR |
Contributor
Author
|
@adisuissa, @phlax, |
phlax
approved these changes
Dec 10, 2025
phlax
left a comment
Member
There was a problem hiding this comment.
this is a very good idea - stuff is starting to break here and there where deps are still using native.cc_fun
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use cc_test from rules_cc instead of native.cc_test to be compatible with Bazel 9