Migrate from go_deps.from_file() to explicit go_deps.module() declarations#127
Merged
Conversation
…tions Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Contributor
Author
|
/cc @adisuissa , @keith |
Contributor
Author
|
envoyproxy/envoy#41881 has passed with this version @adisuissa , when you have time to review? |
adisuissa
reviewed
Nov 7, 2025
phlax
reviewed
Nov 7, 2025
phlax
left a comment
Member
There was a problem hiding this comment.
seems reasonable to me - and maybe better from hermeticity pov
what was the reason for shifting ?
i guess downsides are maintaining in 2 places and risk of them being out of sync
Contributor
Author
|
The reason is that we have a dead end in #104 and that is the easiest solution I could find that would remove BUILD in go directory |
Contributor
Author
|
Can this be merged or do you have better idea on how to fix #104 ? |
adisuissa
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #104
Closes #112